The best time to visit Canada is hard to define. Winter's great for skiing and summer preferable for outdoor activities and touring the larger towns. Canada also has resplendent Springs and Autumns. So, it really depends on what you're planning to do once in Canada. In general, winter should be avoided as it gets extremely cold with Artic conditions in the Great North. And winter is long in Canada, lasting from December to April...
